pkgs/top-level/stage.nix: fix allowVariants with variants set#426490
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jul 19, 2025
Merged
pkgs/top-level/stage.nix: fix allowVariants with variants set#426490wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
wolfgangwalther
approved these changes
Jul 19, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
Successfully created backport PR for |
Merged
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
As pointed out by @wolfgangwalther in #400351 (comment), the
allowVariantsconfig option does nothing. This is due to a helper function getting removed and nobody catching thelib.optionalAttrswhich is necessary. This PR fixes that by adding in thelib.optionalAttrsusage.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.